suite-state point format conversion fix #3602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #3600:
Write cycle point format to the DB
suite_params
table if a format exists, even (in the ISO8601 case) if it is the default format. This allows cycle point conversion to work in thecylc suite-state
command and thesuite_state
xtrigger function, if the upstream suite uses the default format but the downstream suite or command does not. (On master, we assumed that conversion is only necessary if the target suite uses a non-default format).(Note I tried to write a unit test for this using
CylcWorkflowTestCase
incylc/flow/tests/util.py
but gave up when mocked objects got in the way of writing to the suite DB. The functional test is simple and easy to understand, at least).Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.